Navbar Redesign with Icons #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2024 15:52
…ator, and added hover effect on navbar items.
…d dynamic title on containers.
adamseth2
reviewed
Nov 16, 2024
src/store/useRoslib.ts
Outdated
| @@ -11,6 +11,7 @@ const SECONDS_TO_TIMESTAMP = 1000; | |||
| export const useRoslibStore = defineStore('roslib', () => { | |||
| const ros = new ROSLIB.Ros({ url: undefined }); | |||
| const isWebSocketConnected = ref<boolean>(false); | |||
| const latency = ref<Number>(0); | |||
There was a problem hiding this comment.
Small thing with typescript. Primitive types string, number and boolean are lowercase while all others you capital the first letter. Change to "number"
|
@Quashnock I resolved the merge conflict above. Make sure do a |
|
Also, looks like CI failed. Make sure you have the formatter enabled. You can format everything using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icons I used from the vue materials UI library. I tested them by temporarily hardcoding the websocket and robot controller states, so you may want to fully test them with actual connections to the robot.
As requested in the discord meeting on 11/15 I added a placeholder ref for latency inside of useRobotLibStore and had the respective TS file export it. The ping indicator should update accordingly when the latency value is changed.
I felt that if we use icons it may be a bit difficult to seperate indicators from clickable tabs, so I gave indicators a different background color and the clickable tabs a hover effect.
Please let me know if you have any questions or run into any issues!